Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the benchmarks to only record/display select benchmarks. #4560

Merged
merged 8 commits into from
Oct 12, 2023

Conversation

MadVikingGod
Copy link
Contributor

Starting work on #4537
This PR does three things

  1. Creates a new make benchmark as an extendable way to add only select benchmarks to the graphs
  2. Moves make test-benchmark to the ci portion. This is done as a step to insure the benchmarks all work.
  3. Reusues the benchmark workflow to use the new make target, and only run against releases

This doesn't change the runner; this workflow must be added to the allowed list. I will start the process if this is the workflow we want to use.
This doesn't change the benchmark-action to push to the benchmark branch, as I can't create that branch without the TC involvement.

@MadVikingGod MadVikingGod added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 26, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #4560 (9ba0202) into main (f14dc12) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4560     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        222     222             
  Lines      17683   17683             
=======================================
- Hits       14392   14390      -2     
- Misses      2991    2993      +2     
  Partials     300     300             

see 1 file with indirect coverage changes

@MadVikingGod MadVikingGod merged commit 8a923d0 into open-telemetry:main Oct 12, 2023
24 checks passed
@MadVikingGod MadVikingGod deleted the mvg/benchmark branch October 12, 2023 17:00
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants