Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exemplar support to OpenCensus bridge #4585

Merged
merged 10 commits into from
Oct 27, 2023
Merged

Add exemplar support to OpenCensus bridge #4585

merged 10 commits into from
Oct 27, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 3, 2023

Fixes #4572

@dashpole dashpole added the pkg:bridges Related to a bridge package label Oct 3, 2023
@dashpole dashpole force-pushed the opencensus_exemplars branch from 978e116 to 7ffb360 Compare October 3, 2023 18:47
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #4585 (e82e113) into main (0f5565a) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4585     +/-   ##
=======================================
+ Coverage   81.4%   81.6%   +0.1%     
=======================================
  Files        225     225             
  Lines      17830   17969    +139     
=======================================
+ Hits       14529   14668    +139     
  Misses      3001    3001             
  Partials     300     300
Files Coverage Δ
bridge/opencensus/internal/ocmetric/metric.go 96.8% <100.0%> (+3.9%) ⬆️

@dashpole dashpole force-pushed the opencensus_exemplars branch 4 times, most recently from 613c169 to b85a5da Compare October 9, 2023 17:16
@dashpole dashpole mentioned this pull request Oct 9, 2023
Merged
@dashpole
Copy link
Contributor Author

dashpole commented Oct 9, 2023 •
edited
Loading

I've split out the error handling changes into #4599. I'll wait to mark it ready for review until it is rebased

@dashpole dashpole changed the title WIP add exemplar support to OpenCensus bridge Add exemplar support to OpenCensus bridge Oct 9, 2023
@dashpole dashpole force-pushed the opencensus_exemplars branch from b85a5da to f5ca747 Compare October 11, 2023 20:20
@dashpole dashpole marked this pull request as ready for review October 11, 2023 20:20
@dashpole dashpole added the enhancement New feature or request label Oct 11, 2023
pellared
pellared reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 I left some minor comments

bridge/opencensus/internal/ocmetric/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/internal/ocmetric/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/internal/ocmetric/metric.go Outdated Show resolved Hide resolved
@dashpole dashpole force-pushed the opencensus_exemplars branch from d3fa94d to ed1c628 Compare October 12, 2023 13:55
MrAlias
MrAlias approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dashpole
Copy link
Contributor Author

dashpole commented Oct 13, 2023 •
edited
Loading

Hold on. Looks like I missed test cases for float32...
Done

@dashpole dashpole force-pushed the opencensus_exemplars branch 3 times, most recently from da07a5d to 477ab2d Compare October 13, 2023 17:02
@dashpole dashpole force-pushed the opencensus_exemplars branch from 477ab2d to f495b5d Compare October 17, 2023 19:45
@MrAlias
Copy link
Contributor

MrAlias commented Oct 20, 2023

@open-telemetry/go-approvers PTAL. This needs one more review from a non-Splunker.

@MadVikingGod MadVikingGod merged commit a2e3e46 into open-telemetry:main Oct 27, 2023
24 checks passed
@dashpole dashpole deleted the opencensus_exemplars branch October 27, 2023 16:56
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
@pellared pellared mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@pellared pellared pellared approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

OpenCensus bridge MUST support exemplars
4 participants
@dashpole @MrAlias @MadVikingGod @pellared