-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus exporter no longer collects metrics after shutdown #4648
Merged
MadVikingGod
merged 4 commits into
open-telemetry:main
from
dashpole:prometheus_restart
Oct 25, 2023
Merged
Prometheus exporter no longer collects metrics after shutdown #4648
MadVikingGod
merged 4 commits into
open-telemetry:main
from
dashpole:prometheus_restart
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
bug
Something isn't working
pkg:exporter:prometheus
Related to the Prometheus exporter package
labels
Oct 20, 2023
dashpole
force-pushed
the
prometheus_restart
branch
2 times, most recently
from
October 20, 2023 20:12
6593aaf
to
2dfd6f1
Compare
Codecov Report
@@ Coverage Diff @@
## main #4648 +/- ##
=====================================
Coverage 81.3% 81.4%
=====================================
Files 225 225
Lines 17725 17728 +3
=====================================
+ Hits 14427 14431 +4
Misses 2998 2998
+ Partials 300 299 -1
|
dashpole
force-pushed
the
prometheus_restart
branch
from
October 20, 2023 20:14
2dfd6f1
to
d372d5f
Compare
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
October 20, 2023 20:14
MrAlias
reviewed
Oct 20, 2023
dashpole
force-pushed
the
prometheus_restart
branch
from
October 23, 2023 13:38
d372d5f
to
fd16ce3
Compare
MrAlias
approved these changes
Oct 23, 2023
pellared
approved these changes
Oct 23, 2023
MadVikingGod
approved these changes
Oct 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4032.
Before the fix, the test case fails with: