Replace fail-on-alert
with comment-on-alert
on benchmark test
#5671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4537
The
fail-on-alert
would fail the entire benchmark CI like this https://github.com/open-telemetry/opentelemetry-go/actions/runs/10235553562/job/28367685489. With this behavior, we are not able to cache the benchmark result, thus the next benchmark cannot find the previous result to compare. https://github.com/open-telemetry/opentelemetry-go/actions/runs/10250450573This PR replaces
fail-on-alert
withcomment-on-alert
, so the benchmark of the next commit can always find the result from the previous commit even if the previous CI triggers an alert. And, we can still receive the alert by comment, like this benchmark-action/github-action-benchmark@077dde1#commitcomment-36047186.