-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move opentelemetry-extension-aws to contrib #4831
Comments
There are several instrumentations that reference the |
Option 1 sounds good to me also. We'll probably figure out the general instrumentation vs contrib story eventually, but not today 😄. |
@jkwatson if you agree the first option I'll go ahead and get started on that by copying the code to contrib and deprecating it here. |
It replaces : ``` io.opentelemetry:opentelemetry-sdk-extension-aws ``` with: ``` io.opentelemetry.contrib:opentelemetry-aws-resources ``` and: ``` io.opentelemetry.contrib:opentelemetry-aws-xray-propagator ``` see: open-telemetry/opentelemetry-java#4945 open-telemetry/opentelemetry-java#4831 it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha > Version 1.34.0 targets the OpenTelemetry SDK 1.34.0. As we are in 1.36.0 I think this is the correct version to use for it.
* test: adds a test-suite-xray module This adds a test-suite-xray module to verify the following dependencies are resolvables without specifying the version: io.opentelemetry:opentelemetry-exporter-otlp io.opentelemetry:opentelemetry-extension-aws io.opentelemetry.instrumentation:opentelemetry-aws-sdk-2.2 * bug: replace opentelemetry-sdk-extension-aws mentions It replaces : ``` io.opentelemetry:opentelemetry-sdk-extension-aws ``` with: ``` io.opentelemetry.contrib:opentelemetry-aws-resources ``` and: ``` io.opentelemetry.contrib:opentelemetry-aws-xray-propagator ``` see: open-telemetry/opentelemetry-java#4945 open-telemetry/opentelemetry-java#4831 it updates to https://github.com/open-telemetry/opentelemetry-java-contrib 1.34.0-Alpha > Version 1.34.0 targets the OpenTelemetry SDK 1.34.0. As we are in 1.36.0 I think this is the correct version to use for it.
This is the last remaining item of #4661. Splitting it out to avoid the noise of the larger conversation.
Here's the last comment about
opentelemetry-extension-aws
:We've decided we don't need to publish stable artifacts forever. The only reason not to move it to
opentelemetry-java-contrib
today is because the otel java agent still includes it. Here are the options I see:I like options 1 and 3 the best. Option 2 makes sense if we foresee a growing number of instrumentations in contrib. I'm against option 4.
The text was updated successfully, but these errors were encountered: