Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude all, not just span, generated semconv from coverage #2872

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Feb 18, 2021

Removed already removed path pre-deprecation too

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #2872 (74f265a) into main (49f4bd0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2872      +/-   ##
============================================
+ Coverage     89.92%   89.97%   +0.04%     
- Complexity     2657     2658       +1     
============================================
  Files           310      310              
  Lines          8409     8409              
  Branches        839      839              
============================================
+ Hits           7562     7566       +4     
+ Misses          593      587       -6     
- Partials        254      256       +2     
Impacted Files Coverage Δ Complexity Δ
.../opentelemetry/api/internal/OtelEncodingUtils.java 100.00% <100.00%> (ø) 27.00 <2.00> (ø)
...c/main/java/io/opentelemetry/api/trace/SpanId.java 100.00% <100.00%> (ø) 15.00 <3.00> (+1.00)
.../main/java/io/opentelemetry/api/trace/TraceId.java 100.00% <100.00%> (ø) 16.00 <3.00> (+1.00)
...dk/extension/trace/jaeger/sampler/RateLimiter.java 94.11% <0.00%> (-5.89%) 4.00% <0.00%> (-1.00%)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 88.59% <0.00%> (+4.38%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e96b3...74f265a. Read the comment docs.

@anuraaga anuraaga merged commit 0eb4fb2 into open-telemetry:main Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants