Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sampler configuration factory #5763

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Aug 24, 2023

Builds on #5751, #5687, #5399, #5757, #5758 by adding logic to interpret the sampler portion of configuration schema.

@jack-berg jack-berg requested a review from a team August 24, 2023 15:15
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 91.52% and project coverage change: -0.01% ⚠️

Comparison is base (d64793a) 91.37% compared to head (fc0a620) 91.36%.
Report is 2 commits behind head on main.

❗ Current head fc0a620 differs from pull request most recent head 886792b. Consider uploading reports for the commit 886792b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5763      +/-   ##
============================================
- Coverage     91.37%   91.36%   -0.01%     
- Complexity     5208     5214       +6     
============================================
  Files           582      582              
  Lines         15417    15449      +32     
  Branches       1479     1488       +9     
============================================
+ Hits          14087    14115      +28     
  Misses          915      915              
- Partials        415      419       +4     
Files Changed Coverage Δ
...extension/incubator/fileconfig/FileConfigUtil.java 50.00% <50.00%> (-10.00%) ⬇️
...extension/incubator/fileconfig/SamplerFactory.java 92.72% <92.72%> (ø)
...on/incubator/fileconfig/TracerProviderFactory.java 93.33% <100.00%> (+1.02%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +17 to +20
static <T> T addAndReturn(List<Closeable> closeables, T closeable) {
if (closeable instanceof Closeable) {
closeables.add((Closeable) closeable);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that because the Jaeger sampler is Closeable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@jack-berg jack-berg merged commit 3a709a7 into open-telemetry:main Aug 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants