Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus exporter: omit empty otel_scope_info and otel_target_info metrics #5887

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Prometheus exporter: omit empty otel_scope_info and otel_target_info metrics #5887

merged 1 commit into from
Oct 11, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 6, 2023

Resolves #5872

@laurit laurit requested a review from a team October 6, 2023 11:51
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
.../opentelemetry/exporter/prometheus/Serializer.java 87.09% <100.00%> (-0.16%) ⬇️

📢 Thoughts on this report? Let us know!.

@jack-berg jack-berg merged commit 3c52cdf into open-telemetry:main Oct 11, 2023
17 checks passed
@cyrille-leclerc
Copy link
Member

I think the title of this PR is misleading, the generated info metric is not otel_target_info but just target_info:

https://github.com/laurit/opentelemetry-java/blob/3827ee1e5b9dd34db715a0f1675f59e40382f611/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Serializer.java#L251-L255

@laurit laurit deleted the prometheus-empty-resource branch December 4, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole left review comments

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus exporter: omit empty otel_scope_info and otel_target_info metrics
5 participants
@laurit @cyrille-leclerc @dashpole @jack-berg @mateuszrzeszutek