Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to access version.properties API file with GraalVM native #6095

Conversation

jeanbisutti
Copy link
Member

The opentelemetry-api jar has a version.properties files. The PR allows access to this file with a GraalVM native execution.

@jeanbisutti jeanbisutti requested a review from a team December 22, 2023 14:55
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eea1fe0) 91.12% compared to head (6a9adbe) 91.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6095      +/-   ##
============================================
- Coverage     91.12%   91.11%   -0.01%     
  Complexity     5736     5736              
============================================
  Files           628      628              
  Lines         16810    16810              
  Branches       1662     1662              
============================================
- Hits          15318    15317       -1     
  Misses         1028     1028              
- Partials        464      465       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 4f6cc70 into open-telemetry:main Jan 2, 2024
18 checks passed
@jack-berg
Copy link
Member

Looking closer at this, where does this package access version.properties? If source code needs to access the artifact version, it uses the generated OtelVersion.VERSION constant, as shown here: https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/common/src/main/java/io/opentelemetry/sdk/resources/Resource.java#L60

Not sure what this change aimed to accomplish.

@jack-berg jack-berg mentioned this pull request Jan 9, 2024
@jeanbisutti
Copy link
Member Author

version.properties

OK, I have just seen that the OtelVersion class is generated by a Gradle plugin with the current version, that removes the need of this GraalVM configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants