Add Compressor SPI support to OtlpGrpc{Signal}Exporters #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6103 +/- ##
============================================
+ Coverage 90.98% 91.04% +0.05%
+ Complexity 5672 5669 -3
============================================
Files 620 620
Lines 16535 16553 +18
Branches 1682 1689 +7
============================================
+ Hits 15045 15071 +26
+ Misses 1013 994 -19
- Partials 477 488 +11 ☔ View full report in Codecov by Sentry. |
|
@open-telemetry/java-approvers PTAL when you can. This shouldn't be controversial. |
breedx-splk
reviewed
Jan 30, 2024
.../all/src/main/java/io/opentelemetry/exporter/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Jan 30, 2024
.../all/src/main/java/io/opentelemetry/exporter/otlp/metrics/OtlpGrpcMetricExporterBuilder.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Jan 30, 2024
| @@ -703,6 +720,8 @@ void validConfig() { | |||
| .doesNotThrowAnyException(); | |||
|
|
|||
| assertThatCode(() -> exporterBuilder().setCompression("gzip")).doesNotThrowAnyException(); | |||
| // SPI compressor available for this test but not packaged with OTLP exporter | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5990.
Resolves #5196.