PrometheusHttpServer prevent concurrent reads when reusable memory mode #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6371 +/- ##
=========================================
Coverage 91.10% 91.10%
- Complexity 5772 5773 +1
=========================================
Files 627 627
Lines 16852 16854 +2
Branches 1720 1721 +1
=========================================
+ Hits 15353 15355 +2
Misses 1005 1005
Partials 494 494 ☔ View full report in Codecov by Sentry. |
jkwatson
approved these changes
Apr 18, 2024
anuraaga
reviewed
Apr 23, 2024
| // When memory mode is REUSABLE_DATA, concurrent reads lead to data corruption. To prevent this, | ||
| // we configure prometheus with a single thread executor such that requests are handled | ||
| // sequentially. | ||
| if (memoryMode == MemoryMode.REUSABLE_DATA) { |
There was a problem hiding this comment.
Should this be executor == null && memoryMode == REUSABLE? Or otherwise the builder should prevent setting both?
There was a problem hiding this comment.
👋
I left a comment on the PrometheusHttpServerBuilder javadoc stating that if you set memory mode, setExecutor is ignored. We could be stricter and throw if both are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6304. PeriodicMetricReader already has locks in place which prevent concurrent reads and ensure safe access when memory mode is reusable, but PrometheusHttpServer needs an equivalent mechanism.