Retry ConnectException, add retry logging #6614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6614 +/- ##
============================================
- Coverage 90.19% 90.08% -0.12%
+ Complexity 6281 6277 -4
============================================
Files 697 697
Lines 18903 18944 +41
Branches 1852 1858 +6
============================================
+ Hits 17050 17065 +15
- Misses 1281 1305 +24
- Partials 572 574 +2 ☔ View full report in Codecov by Sentry. |
…y-java into retry-connect-exception
|
@open-telemetry/java-approvers would be great to get this approved and merged before this week's release. |
Merged
breedx-splk
reviewed
Aug 8, 2024
| .isTrue()); | ||
|
|
||
| verify(mockHttpClient, times(2)).send(any(), any()); | ||
| } |
jaydeluca
approved these changes
Aug 9, 2024
jaydeluca
reviewed
Aug 9, 2024
.../okhttp/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/RetryInterceptor.java
Outdated
Show resolved
Hide resolved
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6587.
I figured out how to reliably reproduce the
java.net.ConnectExceptionfrom the issue by connecting an unused port onlocalhost. JdkHttpSender was already retrying on these, but OkHttpSender and OkGrpcSender were not.Also added some overdue debug logging for the intermediate retry requests so users have a way of determining what is going on.