Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update all patch versions #2006

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Mar 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
@hapi/hapi (source) 21.3.3 -> 21.3.10 age adoption passing confidence devDependencies patch
@koa/router 12.0.0 -> 12.0.1 age adoption passing confidence devDependencies patch
@types/aws-lambda (source) 8.10.122 -> 8.10.143 age adoption passing confidence dependencies patch
@types/chai (source) 4.3.12 -> 4.3.17 age adoption passing confidence devDependencies patch
@types/express (source) 4.17.18 -> 4.17.21 age adoption passing confidence devDependencies patch
@​types/lru-cache 7.10.9 -> 7.10.10 age adoption passing confidence devDependencies patch
@types/mysql (source) 2.15.22 -> 2.15.26 age adoption passing confidence dependencies patch
@types/pg-pool (source) 2.0.4 -> 2.0.6 age adoption passing confidence dependencies patch
@types/react (source) 17.0.67 -> 17.0.80 age adoption passing confidence devDependencies patch
@types/restify (source) 4.3.10 -> 4.3.12 age adoption passing confidence devDependencies patch
@types/semver (source) 7.5.3 -> 7.5.8 age adoption passing confidence devDependencies patch
@types/semver (source) 7.5.5 -> 7.5.8 age adoption passing confidence devDependencies patch
@types/sinon (source) 17.0.3 -> 10.0.20 age adoption passing confidence devDependencies patch
@types/sinon (source) 10.0.18 -> 10.0.20 age adoption passing confidence devDependencies patch
@web/dev-server-rollup (source) 0.6.1 -> 0.6.4 age adoption passing confidence devDependencies patch
@web/test-runner (source) 0.18.1 -> 0.18.3 age adoption passing confidence devDependencies patch
glob 10.4.1 -> 10.4.5 age adoption passing confidence devDependencies patch
googleapis/release-please-action v4.1.1 -> v4.1.3 age adoption passing confidence action patch
karma (source) 6.4.3 -> 6.4.4 age adoption passing confidence devDependencies patch
memcached 1.6.21-alpine -> 1.6.29-alpine age adoption passing confidence service patch
minimatch 9.0.4 -> 9.0.5 age adoption passing confidence devDependencies patch
rimraf 5.0.5 -> 5.0.10 age adoption passing confidence devDependencies patch
semver 7.5.4 -> 7.6.3 age adoption passing confidence devDependencies patch
semver 7.6.0 -> 7.6.3 age adoption passing confidence devDependencies patch
semver 7.6.0 -> 7.6.3 age adoption passing confidence dependencies patch
socket.io 4.7.4 -> 4.7.5 age adoption passing confidence devDependencies patch
socket.io-client 4.7.4 -> 4.7.5 age adoption passing confidence devDependencies patch
sqlite3 5.1.6 -> 5.1.7 age adoption passing confidence devDependencies patch
winston-transport 4.7.0 -> 4.7.1 age adoption passing confidence dependencies patch

Release Notes

hapijs/hapi (@​hapi/hapi)

v21.3.10

Compare Source

v21.3.9

Compare Source

v21.3.8

Compare Source

v21.3.7

Compare Source

v21.3.6

Compare Source

v21.3.5

Compare Source

v21.3.4

Compare Source

koajs/router (@​koa/router)

v12.0.1

Compare Source

modernweb-dev/web (@​web/dev-server-rollup)

v0.6.4

Compare Source

Patch Changes
  • 2031b9e: Bumping the version of whatwg-url in order to resolve an issue with a dependency.

v0.6.3

Compare Source

Patch Changes

v0.6.2

Compare Source

Patch Changes
  • 8552a4a: dedupe imports from outside root
modernweb-dev/web (@​web/test-runner)

v0.18.3

Compare Source

Patch Changes
  • 6914f3b: Show suites names for summaryReporter when flatten option is true

v0.18.2

Compare Source

Patch Changes
  • 6a97a69: Unify visual-written representation of skipped tests.
isaacs/node-glob (glob)

v10.4.5

Compare Source

v10.4.4

Compare Source

v10.4.3

Compare Source

v10.4.2

Compare Source

googleapis/release-please-action (googleapis/release-please-action)

v4.1.3

Compare Source

Bug Fixes

v4.1.2

Compare Source

Bug Fixes
karma-runner/karma (karma)

v6.4.4

Compare Source

isaacs/minimatch (minimatch)

v9.0.5

Compare Source

isaacs/rimraf (rimraf)

v5.0.10

Compare Source

v5.0.9

Compare Source

v5.0.8

Compare Source

v5.0.7

Compare Source

v5.0.6

Compare Source

npm/node-semver (semver)

v7.6.3

Compare Source

Bug Fixes
Documentation

v7.6.2

Compare Source

Bug Fixes

v7.6.1

Compare Source

Bug Fixes
Dependencies
Chores
socketio/socket.io (socket.io)

v4.7.5

Compare Source

Bug Fixes
  • close the adapters when the server is closed (bf64870)
  • remove duplicate pipeline when serving bundle (e426f3e)
Links
socketio/socket.io-client (socket.io-client)

v4.7.5

Compare Source

Bug Fixes
  • discard acknowledgements upon disconnection (34cbfbb)
Dependencies
TryGhost/node-sqlite3 (sqlite3)

v5.1.7

Compare Source

What's Changed

New Contributors

Full Changelog: TryGhost/node-sqlite3@v5.1.6...v5.1.7

winstonjs/winston-transport (winston-transport)

v4.7.1

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@trentm
Copy link
Contributor

trentm commented Jul 29, 2024

I wonder if this is related to a . character in the name (the actual directory is plugins/node/instrumentation-socket.io) - possible renovate bug? May be interesting to see if changing the directory name would improve this.

An equivalent "update all patch versions" renovate PR worked before on this dir: #1707 (https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1707/files#diff-d636207fb5a93040a6e203309164d21fd7790a2fe0776ad2b21f1fe4ecbb3a74)

@trentm
Copy link
Contributor

trentm commented Jul 29, 2024

I've started a renovate discussion asking about a possible bug here: renovatebot/renovate#30466

@trentm
Copy link
Contributor

trentm commented Jul 30, 2024

It is a renovate bug. I have a PR to fix it: renovatebot/renovate#30483

@trentm
Copy link
Contributor

trentm commented Jul 30, 2024

I have a PR to fix it

Merged. We will need a renovate release ... and then whatever deployment process updates the hosted Renovate to use that release.

@trentm
Copy link
Contributor

trentm commented Jul 30, 2024

The fix is in renovate 38.13.0.
I just re-ran this renovate job and it is current using (https://developer.mend.io/github/open-telemetry/opentelemetry-js-contrib/-/job/a863f965-4af9-47f4-85b2-30606f5a78c0):

INFO: Repository started
{
  "renovateVersion": "37.440.7"
}

That release (https://github.com/renovatebot/renovate/releases/tag/37.440.7) was from last week. I'm not sure if there will be a delay updating production hosted Renovate to v38.
There are some breaking changes: https://github.com/renovatebot/renovate/releases/tag/38.0.0

@renovate-bot renovate-bot force-pushed the renovate/all-patch branch 2 times, most recently from b927203 to 11fd51d Compare July 31, 2024 21:37
@trentm
Copy link
Contributor

trentm commented Aug 9, 2024

I tried to get Renovate to update this PR by clicking the checkbox in the description. That seemed to kick off this job:
https://developer.mend.io/github/open-telemetry/opentelemetry-js-contrib/-/job/019138f1-2e90-7e74-83e4-2cf1a215b2a4

It shows that this version of Renovate was run:

INFO: Repository started
{
  "renovateVersion": "38.20.1"
}

That version should include the fix I got into Renovate for the . in the package name.

However, there was no impact on this PR, so I'm not sure what to do here.
@pichlermarc Ideas?

@trentm trentm removed the stale label Aug 14, 2024
@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

I clicked the checkbox to retry this PR and the job (https://developer.mend.io/github/open-telemetry/opentelemetry-js-contrib/-/job/0191520c-36d4-73ee-85d7-568cddaef0f4) did so.

@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

Unit tests all failed in npm run compile with:

 Error: test/documentLoad.test.ts(264,7): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
Error: test/documentLoad.test.ts(311,7): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
Error: test/documentLoad.test.ts(312,7): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
Error: test/documentLoad.test.ts(351,9): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
Error: test/documentLoad.test.ts(544,9): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
Error: test/documentLoad.test.ts(550,9): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
Error: test/documentLoad.test.ts(626,9): error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
npm ERR! Lifecycle script `compile` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @opentelemetry/[email protected] 
npm ERR!   at location: /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/plugins/web/opentelemetry-instrumentation-document-load 

@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

Downgrading the @types/chai version "fixes" this:

% cd plugins/web/opentelemetry-instrumentation-document-load
% npm install @types/[email protected]
% npm run compile

Here is the diff in those @types/chai versions:
https://gist.github.com/trentm/be37b10e8e38e1452f64f76761d9c5b5

Via https://stackoverflow.com/a/72689922 this is because:

  1. TypeScript has a design limitation: asserts x is type doesn't work when using arrow functions microsoft/TypeScript#34523

    asserts x is type doesn't work when using arrow functions

  2. That @types/chai update added usages of asserts x is type, e.g.: https://gist.github.com/trentm/be37b10e8e38e1452f64f76761d9c5b5#file-the-diff-L56

Super.

A total guess is that the latest @types/chai isn't compatible -- for this particular issue -- with the older chai that we have?

@trentm trentm closed this Aug 14, 2024
@trentm trentm reopened this Aug 14, 2024
@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

I don't recall "closing" this. Re-opened.

@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

So I guess we could pin to the particular @types/chai verison.

DefinitelyTyped/DefinitelyTyped#69364 is the PR that added these assertions to @types/chai.

@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

Apparently this works:

diff --git a/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts b/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
index a239945b..cbe4b0c7 100644
--- a/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
+++ b/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
@@ -45,7 +45,7 @@ import {
 } from '@opentelemetry/semantic-conventions';
 import { EventNames } from '../src/enums/EventNames';

-const { assert } = chai as typeof import('chai');
+const assert = chai.assert;

 const exporter = new InMemorySpanExporter();
 const provider = new BasicTracerProvider();

The ways of TS are mysterious to me.

Was getting compilation errors like this:

test/documentLoad.test.ts:264:7 - error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.

264       assert.ok(plugin instanceof DocumentLoadInstrumentation);
          ~~~~~~~~~

  test/documentLoad.test.ts:48:9
    48 const { assert } = chai as typeof import('chai');
               ~~~~~~
    'assert' needs an explicit type annotation.
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@trentm
Copy link
Contributor

trentm commented Aug 14, 2024

Tests are still failing (TAV v22 and v20)... for a different reason. I cancelled the workflow.

Note the warning about unhelpful npm behaviour in this workspace
when the version of mongodb to test (by TAV) matches the version
installed for the instrumentation-mongoose workspace. The version
in instr-mongoose recently updated (in open-telemetry#2353), so it needs to
update here as well.
@trentm
Copy link
Contributor

trentm commented Aug 15, 2024

^^^ That commit is a fix for the fialing mongo TAV tests.

Note the warning about unhelpful npm behaviour in this workspace
when the version of mongodb to test (by TAV) matches the version
installed for the instrumentation-mongoose workspace. The version
in instr-mongoose recently updated (in #2353), so it needs to
update here as well.

@trentm
Copy link
Contributor

trentm commented Aug 15, 2024

Summary of changes beyond what renovate added here:

  1. We got a fix into renovate to copy with a workspace dir having a dot in it (instrumentation-socket.io): chore(deps): update all patch versions #2006 (comment)
  2. A change to documentLoad.test.ts to workaround an interaction between a design limitation in TypeScript and usage in a @types/chai update that tickled that limitation: chore(deps): update all patch versions #2006 (comment) chore(deps): update all patch versions #2006 (comment)
  3. An update to the version of mongodb to skip in test-all-versions (TAV) tests because (a) npm has a bug/limitation in how it locally resolves npm install --no-save [email protected] (as tav calls it) when in a workspace that has that [email protected] installed at a higher level and (b) instrumentation-mongoose recently updated its pinned mongodb dep version to 4.7.2: chore(deps): update all patch versions #2006 (comment)

@trentm trentm merged commit b169191 into open-telemetry:main Aug 15, 2024
21 checks passed
@trentm trentm mentioned this pull request Nov 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pkg:auto-configuration-propagators pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:host-metrics pkg:id-generator-aws-xray pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:plugin-react-load pkg:propagator-instana pkg:propagator-ot-trace pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants