-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update all patch versions #2006
Conversation
An equivalent "update all patch versions" renovate PR worked before on this dir: #1707 (https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1707/files#diff-d636207fb5a93040a6e203309164d21fd7790a2fe0776ad2b21f1fe4ecbb3a74) |
412cef0
to
ccd8e00
Compare
I've started a renovate discussion asking about a possible bug here: renovatebot/renovate#30466 |
It is a renovate bug. I have a PR to fix it: renovatebot/renovate#30483 |
Merged. We will need a renovate release ... and then whatever deployment process updates the hosted Renovate to use that release. |
ccd8e00
to
7648665
Compare
The fix is in renovate 38.13.0.
That release (https://github.com/renovatebot/renovate/releases/tag/37.440.7) was from last week. I'm not sure if there will be a delay updating production hosted Renovate to v38. |
b927203
to
11fd51d
Compare
I tried to get Renovate to update this PR by clicking the checkbox in the description. That seemed to kick off this job: It shows that this version of Renovate was run:
That version should include the fix I got into Renovate for the However, there was no impact on this PR, so I'm not sure what to do here. |
11fd51d
to
5659ab9
Compare
I clicked the checkbox to retry this PR and the job (https://developer.mend.io/github/open-telemetry/opentelemetry-js-contrib/-/job/0191520c-36d4-73ee-85d7-568cddaef0f4) did so. |
Unit tests all failed in
|
Downgrading the
Here is the diff in those Via https://stackoverflow.com/a/72689922 this is because:
Super. A total guess is that the latest |
I don't recall "closing" this. Re-opened. |
So I guess we could pin to the particular DefinitelyTyped/DefinitelyTyped#69364 is the PR that added these assertions to |
Apparently this works: diff --git a/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts b/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
index a239945b..cbe4b0c7 100644
--- a/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
+++ b/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
@@ -45,7 +45,7 @@ import {
} from '@opentelemetry/semantic-conventions';
import { EventNames } from '../src/enums/EventNames';
-const { assert } = chai as typeof import('chai');
+const assert = chai.assert;
const exporter = new InMemorySpanExporter();
const provider = new BasicTracerProvider(); The ways of TS are mysterious to me. |
Was getting compilation errors like this: test/documentLoad.test.ts:264:7 - error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation. 264 assert.ok(plugin instanceof DocumentLoadInstrumentation); ~~~~~~~~~ test/documentLoad.test.ts:48:9 48 const { assert } = chai as typeof import('chai'); ~~~~~~ 'assert' needs an explicit type annotation.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Tests are still failing (TAV v22 and v20)... for a different reason. I cancelled the workflow. |
Note the warning about unhelpful npm behaviour in this workspace when the version of mongodb to test (by TAV) matches the version installed for the instrumentation-mongoose workspace. The version in instr-mongoose recently updated (in open-telemetry#2353), so it needs to update here as well.
^^^ That commit is a fix for the fialing mongo TAV tests.
|
Summary of changes beyond what renovate added here:
|
This PR contains the following updates:
21.3.3
->21.3.10
12.0.0
->12.0.1
8.10.122
->8.10.143
4.3.12
->4.3.17
4.17.18
->4.17.21
7.10.9
->7.10.10
2.15.22
->2.15.26
2.0.4
->2.0.6
17.0.67
->17.0.80
4.3.10
->4.3.12
7.5.3
->7.5.8
7.5.5
->7.5.8
17.0.3
->10.0.20
10.0.18
->10.0.20
0.6.1
->0.6.4
0.18.1
->0.18.3
10.4.1
->10.4.5
v4.1.1
->v4.1.3
6.4.3
->6.4.4
1.6.21-alpine
->1.6.29-alpine
9.0.4
->9.0.5
5.0.5
->5.0.10
7.5.4
->7.6.3
7.6.0
->7.6.3
7.6.0
->7.6.3
4.7.4
->4.7.5
4.7.4
->4.7.5
5.1.6
->5.1.7
4.7.0
->4.7.1
Release Notes
hapijs/hapi (@hapi/hapi)
v21.3.10
Compare Source
v21.3.9
Compare Source
v21.3.8
Compare Source
v21.3.7
Compare Source
v21.3.6
Compare Source
v21.3.5
Compare Source
v21.3.4
Compare Source
koajs/router (@koa/router)
v12.0.1
Compare Source
072b545
147a934
9a45a3b
04884de
8d390a9
bc13548
ae98680
ceb3d16
modernweb-dev/web (@web/dev-server-rollup)
v0.6.4
Compare Source
Patch Changes
2031b9e
: Bumping the version of whatwg-url in order to resolve an issue with a dependency.v0.6.3
Compare Source
Patch Changes
v0.6.2
Compare Source
Patch Changes
8552a4a
: dedupe imports from outside rootmodernweb-dev/web (@web/test-runner)
v0.18.3
Compare Source
Patch Changes
6914f3b
: Show suites names forsummaryReporter
whenflatten
option is truev0.18.2
Compare Source
Patch Changes
6a97a69
: Unify visual-written representation of skipped tests.isaacs/node-glob (glob)
v10.4.5
Compare Source
v10.4.4
Compare Source
v10.4.3
Compare Source
v10.4.2
Compare Source
googleapis/release-please-action (googleapis/release-please-action)
v4.1.3
Compare Source
Bug Fixes
v4.1.2
Compare Source
Bug Fixes
karma-runner/karma (karma)
v6.4.4
Compare Source
isaacs/minimatch (minimatch)
v9.0.5
Compare Source
isaacs/rimraf (rimraf)
v5.0.10
Compare Source
v5.0.9
Compare Source
v5.0.8
Compare Source
v5.0.7
Compare Source
v5.0.6
Compare Source
npm/node-semver (semver)
v7.6.3
Compare Source
Bug Fixes
73a3d79
#726 optimize Range parsing and formatting (#726) (@jviide)Documentation
2975ece
#719 fix extra backtick typo (#719) (@stdavis)v7.6.2
Compare Source
Bug Fixes
6466ba9
#713 lru: use map.delete() directly (#713) (@negezor, @lukekarrys)v7.6.1
Compare Source
Bug Fixes
c570a34
#704 linting: no-unused-vars (@wraithgar)ad8ff11
#704 use internal cache implementation (@mbtools)ac9b357
#682 typo in compareBuild debug message (#682) (@mbtools)Dependencies
988a8de
#709 uninstalllru-cache
(#709)3fabe4d
#704 remove lru-cacheChores
dd09b60
#705 bump @npmcli/template-oss to 4.22.0 (@lukekarrys)ec49cdc
#701 chore: chore: postinstall for dependabot template-oss PR (@lukekarrys)b236c3d
#696 add benchmarks (#696) (@H4ad)692451b
#688 various improvements to README (#688) (@mbtools)5feeb7f
#705 postinstall for dependabot template-oss PR (@lukekarrys)074156f
#701 bump @npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot])socketio/socket.io (socket.io)
v4.7.5
Compare Source
Bug Fixes
Links
engine.io@~6.5.2
(no change)ws@~8.11.0
(no change)socketio/socket.io-client (socket.io-client)
v4.7.5
Compare Source
Bug Fixes
Dependencies
engine.io-client@~6.5.2
(no change)ws@~8.11.0
(no change)TryGhost/node-sqlite3 (sqlite3)
v5.1.7
Compare Source
What's Changed
@mapbox/node-pre-gyp
withprebuild
+prebuild-install
(TryGhost/node-sqlite3@605c7f9) by @daniellockyerRowToJS
performance by removingNapi::String::New
instantiation by @daniellockyerNew Contributors
Full Changelog: TryGhost/node-sqlite3@v5.1.6...v5.1.7
winstonjs/winston-transport (winston-transport)
v4.7.1
Compare Source
5b4d9bf
17feb48
719a76b
c30789a
Configuration
📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.