-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update contributing guidelines for required org membership #2548
base: main
Are you sure you want to change the base?
docs: update contributing guidelines for required org membership #2548
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
=======================================
Hits 7277 7277
Misses 741 741 |
Isn't https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.github/workflows/component-owners.yml already meant to be handling assigning PRs to and/or request reviews from component owners? From https://github.com/dyladan/component-owners#readme
|
Aah, yes I completely forgot about this 🤦 Anyway I think we can still do something similar with |
@trentm @pichlermarc I removed the references to CODEOWNERS and just kept in the triagers role and the requirement of being in otel org. |
Which problem is this PR solving?
It should be easier to auto-assign issues and PRs and grant more authority to codeowners on specific packages.
This came up while reviewing the react-native instrumentation, which is currently the top requested feature in the repo. We want to delegate responsibly, while still keeping a high bar for adding instrumentations.
Short description of the changes
Update contributing guidelines to