-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(aws-sdk): migrate SEMATTRS_*
to ATTR_*
#2550
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
+ Coverage 90.75% 90.81% +0.05%
==========================================
Files 169 169
Lines 8018 8021 +3
Branches 1632 1632
==========================================
+ Hits 7277 7284 +7
+ Misses 741 737 -4
|
SEMATTRS_*
to ATTR_*
plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/lambda.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/sns.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
The majority of replacements were good, but there are a few that you didn't just update the semantic convention, but you change the actual key being used, this needs to be clarified.
faae679
to
3626c52
Compare
ad845bd
to
6333ee3
Compare
Which problem is this PR solving?
SEMATTRS_*
were deprecated in@opentelemetry/[email protected]
https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#migrating-from-semattrs_-semresattrs_-Short description of the changes
SEMATTRS_*
toATTR_*
wherever a replacement is available. The ones without replacement are deprecated, and can be removed in future PRs.