Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow to format using prettier #2552

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 26, 2024

Which problem is this PR solving?

Short description of the changes

@trivikr trivikr marked this pull request as ready for review November 26, 2024 16:04
@trivikr trivikr requested a review from a team as a code owner November 26, 2024 16:04
@trivikr
Copy link
Contributor Author

trivikr commented Nov 26, 2024

cc @pichlermarc who'd enabled workflow for previous PR.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (2784357) to head (3705ed7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
+ Coverage   90.75%   90.80%   +0.04%     
==========================================
  Files         169      169              
  Lines        8018     8018              
  Branches     1632     1632              
==========================================
+ Hits         7277     7281       +4     
+ Misses        741      737       -4     

see 1 file with indirect coverage changes

@trentm
Copy link
Contributor

trentm commented Nov 28, 2024

I'd like to propose an alternative so that we can get the examples/* being linted using mostly the same eslitn config as the rest of the repo uses (using the top-level "eslint.config.js"). I have a start at supporting this here:
#2567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants