fix(instrumentation-aws-lambda): add 'lint:semconv-deps' #2569
+115
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a lint step that checks that packages in the workspace are following our 'rule' that uses of the semconv pkg 'incubating' entry-point should *pin* the '@opentelemetry/semantic-conventions' dep. This is because (though rare) the incubating/unstable semconv exports can have breaking changes in minors. Refs: open-telemetry#2549 (comment) Refs: open-telemetry/opentelemetry-js#5182
|
Currently there is one package that is breaking this rule: I'll update that dep in a commit on this PR. |
trentm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
+ Coverage 90.75% 90.80% +0.04%
==========================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
==========================================
+ Hits 7277 7281 +4
+ Misses 741 737 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint step that checks that packages in the workspace
are following our 'rule' that uses of the semconv pkg 'incubating'
entry-point should pin the '@opentelemetry/semantic-conventions'
dep. This is because (though rare) the incubating/unstable
semconv exports can have breaking changes in minors.
Refs: #2549 (comment)
Refs: open-telemetry/opentelemetry-js#5182
That "rule" (to pin the semconv package dep when using the incubating entry-point) is the concensus from discussion on open-telemetry/opentelemetry-js#5182
I'm proposing this extra lint step (added to
npm run lint) that will help check that this rule is followed.