-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark tests workflow #4144
Benchmark tests workflow #4144
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4144 +/- ##
==========================================
- Coverage 92.50% 92.30% -0.21%
==========================================
Files 275 329 +54
Lines 7369 9421 +2052
Branches 1540 1980 +440
==========================================
+ Hits 6817 8696 +1879
- Misses 552 725 +173 |
I have updated the URL path in Github pages, so that the test results will be accessible under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this 🙂
@pichlermarc Thanks for the review. There is potentially one more change that I am wondering about - should we run this on release or on every merge to main? With merge to main, it would be easier to catch regressions. What do you think? |
👍 for running it on main 🙂 |
We're already using gh-pages for the reference docs. Will this conflict with that? |
No, it will not conflict. It's set to put the results in a |
Which problem is this PR solving?
This is a follow-up to adding performance benchmark tests (#4105). In order for benchmark tests to provide value, it is important to track changes in performance over time.
Short description of the changes
This adds a Github workflow that runs all benchmark tests and publishes results to Github pages. This is similar to what the Collector is already doing here.
The PR is in a draft mode until self-hosted runner is available to this repo (the process of adding a self-hosted runner is progress).
Type of change
How Has This Been Tested?
The workflow has been tested in a fork. Here is a page with charts that it has generated.