Fixes bug where we tried to default config for the wrong components #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
reviewed
Oct 8, 2024
frzifus
approved these changes
Oct 8, 2024
| @@ -44,15 +44,15 @@ func (g *GenericParser[T]) GetDefaultConfig(logger logr.Logger, config interface | |||
| return config, nil | |||
| } | |||
|
|
|||
| if g.settings.defaultRecAddr == "" { | |||
| if g.settings.defaultRecAddr == "" || g.settings.port == 0 { | |||
| featuregate.StageBeta, | ||
| featuregate.WithRegisterDescription("enables the operator to default the endpoint for known components"), | ||
| featuregate.WithRegisterFromVersion("v0.110.0"), | ||
| ) |
There was a problem hiding this comment.
Since no e2e breaks, I assume its enabled by default? 😄
swiatekm
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Patch for the recent fix in #3333
Link to tracking Issue(s):
Testing:
Unit tests added, manually tested locally.
Documentation: