Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gradle action #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update gradle action #24

wants to merge 1 commit into from

Conversation

trask
Copy link
Member

@trask trask commented Nov 23, 2024

No description provided.

@trask trask requested a review from a team as a code owner November 23, 2024 20:36
breedx-splk
breedx-splk approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Curious of the motivation, however...since it doesn't really "update" the action it switches it completely.

@trask
Copy link
Member Author

trask commented Dec 2, 2024

yeah, my description is definitely lacking 😅

this PR is a combination of these two things that we've done in the other Java repos:

@breedx-splk
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @breedx-splk