Add documenation to README.md and RELEASING.md #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
requested review from
anuraaga,
bogdandrutu and
jkwatson
as code owners
|
Please note that the failing PR build is unrelated as this PR only changes Markdown files. |
jkwatson
approved these changes
Dec 13, 2021
|
something is definitely messed up with the PR build. It's trying to download an unreleased version of the proto zip.... |
anuraaga
reviewed
Dec 13, 2021
|
|
||
| ```groovy | ||
| implementation 'io.opentelemetry.proto:opentelemetry-proto:{{version}}' | ||
| ``` |
There was a problem hiding this comment.
Thanks for the help! Yeah the build fails until a new release of the proto has been made upstream, due to a shortcut to make the release as simple as possible. Will look into improving it
There was a problem hiding this comment.
Thank you for pointing this out. :)
I just wanted to mention it in this PR as it has no effect on the build. Should I create an issue for that in the meantime?
anuraaga
approved these changes
Dec 14, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
README.mdREADME.mdRELEASING.md