Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the inclusivity of exponential histogram bounds #409

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Change the inclusivity of exponential histogram bounds #409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c212c7
Change the exponential histogram boundary condition
Jun 28, 2022
67b4f37
Merge branch 'main' into jmacd/histobounds
jmacd Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,8 @@ message ExponentialHistogramDataPoint {
// base = (2^(2^-scale))
//
// The histogram bucket identified by `index`, a signed integer,
// contains values that are greater than or equal to (base^index) and
// less than (base^(index+1)).
// contains values that are greater than (base^index) and
// less than or equal to (base^(index+1)).
//
// The positive and negative ranges of the histogram are expressed
// separately. Negative values are mapped by their absolute value
Expand Down Expand Up @@ -538,7 +538,7 @@ message ExponentialHistogramDataPoint {

// Count is an array of counts, where count[i] carries the count
// of the bucket at index (offset+i). count[i] is the count of
// values greater than or equal to base^(offset+i) and less than
// values greater than base^(offset+i) and less or equal to than
// base^(offset+i+1).
//
// Note: By contrast, the explicit HistogramDataPoint uses
Expand Down