Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP 1.1 restriction from Protocol Details #571

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 11, 2024

In the Protocol Details section the spec states that it defines how OTLP is implemented over grpc and http 1.1, but later in the document in section OTLP/HTTP it states "Implementations MAY use HTTP/1.1 or HTTP/2 transports."

This may confuse end readers and I suggest that it is easier to drop the 1.1 in the Protocol Details section

@svrnm svrnm requested a review from a team July 11, 2024 13:09
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Stable doc but I believe the change is allowed, since it is a bug (OTLP-over-HTTP indeed is not tied to any particular HTTP version).

@tigrannajaryan tigrannajaryan merged commit 484241a into open-telemetry:main Jul 22, 2024
16 checks passed
@svrnm svrnm deleted the svrnm-patch-1 branch August 8, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants