Add InstrumentationScope and deprecate InstrumentationLibraryInfo #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
lzchen
reviewed
Apr 11, 2022
exporter/opentelemetry-exporter-jaeger-proto-grpc/tests/test_jaeger_exporter_protobuf.py
Show resolved
Hide resolved
lzchen
approved these changes
Apr 11, 2022
ocelotl
approved these changes
Apr 11, 2022
ocelotl
added
the
Approve Public API check
|
@srikanthccv please add a changelog ✌️ |
codeboten
reviewed
Apr 12, 2022
opentelemetry-sdk/src/opentelemetry/sdk/util/instrumentation.py
Outdated
Show resolved
Hide resolved
codeboten
reviewed
Apr 18, 2022
opentelemetry-sdk/src/opentelemetry/sdk/util/instrumentation.py
Outdated
Show resolved
Hide resolved
codeboten
reviewed
Apr 18, 2022
codeboten
reviewed
Apr 19, 2022
Co-authored-by: Alex Boten <[email protected]>
…hon into issue-2516
srikanthccv
commented
Apr 19, 2022
|
Hi! Without the Library -> Scope rename, Honeycomb customers can't send us OTLP traces or metrics with the current OTel Python version (v1.11.0). Our OTel ingest is pinned to an earlier otlp-proto (0.11.0) to support customers who are sending us metrics from older OTel SDKs using behavior that was deprecated last year. We are unable to arrange for data ingest that supports both that deprecated metric format and this deprecated library/scope rename because the deprecated metric behavior was removed before this rename. What can we do to help get this rename merged and released? |
|
|
lzchen
approved these changes
Apr 20, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This spec PR open-telemetry/opentelemetry-specification#2276 introduced the concept of
InstrumentationScope. Naming in our components is varying. The deprecatedInstrumentationLibraryfrom spec isInstrumentationInfo. And the arguments naming have the mixed usage of "module" and "library"instrumenting_module_nameandinstrumenting_library_version. I introduced another class and properties wherever necessary for backward compatibility and replaced in the experimental packages. I would like to test these changes manually but opening it for reviews.Fixes #2516