Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metric-Etw exporter to use 0.27 of api and sdk #128

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

cijothomas
Copy link
Member

Updating just the package, and minimal changes to make it work with new. Internal logging needs to be revisited before release.

@cijothomas cijothomas requested a review from a team as a code owner November 15, 2024 01:56
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.0%. Comparing base (56a6f45) to head (d586db8).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-etw-metrics/src/exporter/mod.rs 77.7% 4 Missing ⚠️
opentelemetry-etw-metrics/src/etw/mod.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #128     +/-   ##
=======================================
+ Coverage   52.3%   56.0%   +3.7%     
=======================================
  Files         38      39      +1     
  Lines       4967    6037   +1070     
=======================================
+ Hits        2598    3385    +787     
- Misses      2369    2652    +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit d407cbf into open-telemetry:main Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants