-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: create metrics from traces and agent based sampling #17
Conversation
@Hartigan Could you clear the EasyCLA check before we can accept any contributions? You may want to consult your employer's legal team, if needed. |
Hi @cijothomas Should I change smth in this pull request(api or add custom implementation of |
I am not an expert in this component, so can't give a specific suggestion. I hope there are DataDog experts or other owners of this component who can help. |
Some unit tests are always welcome! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
+ Coverage 51.7% 52.4% +0.6%
=======================================
Files 37 37
Lines 4918 5026 +108
=======================================
+ Hits 2544 2635 +91
- Misses 2374 2391 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, also make sure to add a comment into the CHANGELOG.md.
@Hartigan Could you resolve conflicts? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert in this particular component, so will wait another day before merge to see if anyone else can help with additional reviews.
@Hartigan could you resolve conflicts, so we can merge? |
Hi
This fraft pull request introduce 2 features from datadog telemetry protocol:
_dd.measured
flag present in span, datadog agent automatically creates metrics from this span.dd-trace-agent
exported to trace-agent. And agent decide export span or not to Datadog cloud service. This decision based on_sampling_priority_v1
flag and trace-agent configuration(ex. force to sample error spans).Described flags, may be propagated or changed by ShouldSample interface
Current code not working, because decision about export trace or not created here