Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver - Fixing wrong in-code documentation for maximum shutdown duration #22

Conversation

ivan-brko
Copy link
Contributor

Fixes

Fixing invalid in-code documentation

Changes

N/A

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ivan-brko ivan-brko requested a review from a team January 5, 2024 19:27
Copy link

linux-foundation-easycla bot commented Jan 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ivan-brko / name: Ivan Brko (5951fd2)
  • ✅ login: cijothomas / name: Cijo Thomas (083f010)

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3827119) 40.4% compared to head (083f010) 40.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #22   +/-   ##
=====================================
  Coverage   40.4%   40.4%           
=====================================
  Files         12      12           
  Lines       1279    1279           
=====================================
  Hits         517     517           
  Misses       762     762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 14e58a4 into open-telemetry:main Jan 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants