Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver - adding support for Google X-Cloud-Trace-Context propagation format #25

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ivan-brko
Copy link
Contributor

@ivan-brko ivan-brko commented Jan 17, 2024

Fixes

Issue #3

Changes

Added GoogleTraceContextPropagator to opentelemetry-stackdriver crate, behind a feature flag propagator.
Implementation is based on the official GCP golang library implementation and Rust opentelemetry implementation of W3C Propagator.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ivan-brko ivan-brko requested a review from a team January 17, 2024 14:13
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3827119) 40.4% compared to head (f537a66) 40.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #25   +/-   ##
=====================================
  Coverage   40.4%   40.4%           
=====================================
  Files         12      12           
  Lines       1279    1279           
=====================================
  Hits         517     517           
  Misses       762     762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivan-brko ivan-brko force-pushed the google_trace_propagator branch 2 times, most recently from 8910d71 to de2a7cd Compare January 18, 2024 07:52
@ivan-brko ivan-brko force-pushed the google_trace_propagator branch from de2a7cd to f537a66 Compare January 18, 2024 07:52
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@cijothomas cijothomas merged commit 8741b95 into open-telemetry:main Jan 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants