feat: add opentelemetry-resource-detector crate #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the implementation of the OS and Process resource detectors as their resource attributes are experimental.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
+ Coverage 50.1% 50.5% +0.4%
=======================================
Files 32 34 +2
Lines 4358 4397 +39
=======================================
+ Hits 2184 2223 +39
Misses 2174 2174 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Mar 13, 2024
| @@ -0,0 +1,18 @@ | |||
| [package] | |||
| name = "opentelemetry-resource-detector" | |||
There was a problem hiding this comment.
Suggested change
| name = "opentelemetry-resource-detector" | |
| name = "opentelemetry-resource-detectors" |
Would it make sense to use plural name, given this has multiple detectors!
There was a problem hiding this comment.
Make sense to me, changed in 380ca69
lalitb
reviewed
Mar 13, 2024
lalitb
reviewed
Mar 13, 2024
lalitb
reviewed
Mar 13, 2024
cijothomas
reviewed
Mar 14, 2024
| } | ||
| } | ||
|
|
||
| #[cfg(target_os = "linux")] |
There was a problem hiding this comment.
nothing linux specific right?
cijothomas
approved these changes
Mar 14, 2024
3 tasks
TommyCpp
reviewed
Mar 15, 2024
| homepage = "https://github.com/open-telemetry/opentelemetry-rust-contrib/tree/main/opentelemetry-resource-detectors" | ||
| repository = "https://github.com/open-telemetry/opentelemetry-rust-contrib/tree/main/opentelemetry-resource-detectors" | ||
| readme = "README.md" | ||
| keywords = ["opentelemetry", "resource", "detector"] |
There was a problem hiding this comment.
Not sure if resource and detector are best keywords. Maybe tracing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the implementation of the OS and Process resource detectors from the opentelemetry-sdk to its own contrib crate. The reason behind it is due to their experimental nature in semantic conventions:
Discussion: open-telemetry/opentelemetry-rust#1610
Changes
Adds a new crate for contrib resource detectors.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes