stackdriver: fix Cargo features for GcpAuthorizer #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
- Coverage 51.9% 51.7% -0.3%
=======================================
Files 37 37
Lines 4896 4918 +22
=======================================
Hits 2544 2544
- Misses 2352 2374 +22 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Mar 15, 2024
TommyCpp
approved these changes
Mar 18, 2024
|
Merging this. @djc I think you are listed as owner of https://crates.io/crates/opentelemetry-stackdriver in crates.io. Do you want to publish a new version? |
|
Yeah, will do! |
|
Published 0.19.1 on crates.io. |
I think this is a weak spot in the toolchain, I think work is ongoing to fix it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#50 regressed the support for actually using the
GcpAuthorizer: it used thedep:gcp_authsyntax for enabling the dependency by default, but the actualGcpAuthorizercode was guarded by agcp_authfeature which didn't exist anymore. Bring back a named feature for this (now calledgcp-authorizerto matchyup-authorizer).This time I will start a PR for my work repository based on my branch to make sure it actually works.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes