Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are we using such a long name as StatusCanonicalCode? #1069

Closed
bogdandrutu opened this issue Oct 6, 2020 · 4 comments · Fixed by #1081
Closed

Why are we using such a long name as StatusCanonicalCode? #1069

bogdandrutu opened this issue Oct 6, 2020 · 4 comments · Fixed by #1081
Assignees
@bogdandrutu
Labels
area:api Cross language API specification issue priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory

Comments

@bogdandrutu
Copy link
Member

From #1067 (comment).

Another question is: Are there non-canonical status codes?
@bogdandrutu bogdandrutu added the spec:trace Related to the specification/trace directory label Oct 6, 2020
@bogdandrutu bogdandrutu mentioned this issue Oct 6, 2020
Merged
@Oberon00
Copy link
Member

Oberon00 commented Oct 6, 2020

I think this should be renamed to just Status (or StatusCategory) after #966. The current enum is not canonical and I also don't know if we want to call it a code.

@arminru arminru added the area:api Cross language API specification issue label Oct 7, 2020
@arminru
Copy link
Member

arminru commented Oct 7, 2020

I don't think this is a blocker for GA but if we intend to change that (and from the 👍 on here we seem to have some consensus), we should do so before GA. It should be a simple find-and-replace for SIGs that have already adopted the new Status model and otherwise it would go well along with that change.

@tigrannajaryan tigrannajaryan mentioned this issue Oct 7, 2020
Merged
@tigrannajaryan
Copy link
Member

I'd prefer to settle this before GA since the names may be part of the API. In that case changing the names will break the API.

tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Oct 9, 2020
Remove "canonical" adjective from Status Code
6990353 
Resolves: open-telemetry#1069
@tigrannajaryan tigrannajaryan mentioned this issue Oct 9, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Oct 9, 2020
Remove "canonical" adjective from Status Code
6e7bf74 
Resolves: open-telemetry#1069
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Oct 9, 2020
Remove "canonical" adjective from Status Code
a64d3cb 
Resolves: open-telemetry#1069
@andrewhsu andrewhsu added release:required-for-ga Must be resolved before GA release, or nice to have before GA priority:p1 Highest priority level labels Oct 9, 2020
@andrewhsu
Copy link
Member

from the issue triage mtg today, need a decision on this whether to have it

tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Oct 14, 2020
Remove "canonical" adjective from Status Code
fbbce6f 
Resolves: open-telemetry#1069
bogdandrutu pushed a commit that referenced this issue Oct 14, 2020
@tigrannajaryan
Remove "canonical" adjective from Status Code (#1081)
f3c1b44 
* Remove "canonical" adjective from Status Code

Resolves: #1069

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdandrutu bogdandrutu

Labels
area:api Cross language API specification issue priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "canonical" adjective from Status Code tigrannajaryan/opentelemetry-specification
5 participants
@andrewhsu @Oberon00 @bogdandrutu @tigrannajaryan @arminru