Check Fetch InstrumentationScope from ReadableSpan Box for PHP #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Jun 20, 2022
tigrannajaryan
approved these changes
Jun 20, 2022
|
@open-telemetry/php-approvers please confirm. |
brettmc
approved these changes
Jun 20, 2022
arminru
approved these changes
Jun 21, 2022
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
…metry#2622) OTEL-PHP at some point switched to using InstrumentationScope instead of InstrumentationLibrary everywhere, which incidentally satisfied the ["Fetch InstrumentationScope from ReadableSpan"](https://github.com/open-telemetry/opentelemetry-specification/blob/9abbdd39d0b35f635f833f072013431da419894e/specification/common/mapping-to-non-otlp.md#instrumentationscope) part of the spec (otel-php is still alpha so it seemed ok to not deprecate the instrumentation library and just remove it's use entirely) Related issues # open-telemetry/opentelemetry-php#705 Related [OTEP(s)](https://github.com/open-telemetry/oteps) # Don't think it was an OTEP but open-telemetry#2276 is where the push for the change originally came from I believe
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…metry#2622) OTEL-PHP at some point switched to using InstrumentationScope instead of InstrumentationLibrary everywhere, which incidentally satisfied the ["Fetch InstrumentationScope from ReadableSpan"](https://github.com/open-telemetry/opentelemetry-specification/blob/9abbdd39d0b35f635f833f072013431da419894e/specification/common/mapping-to-non-otlp.md#instrumentationscope) part of the spec (otel-php is still alpha so it seemed ok to not deprecate the instrumentation library and just remove it's use entirely) Related issues # open-telemetry/opentelemetry-php#705 Related [OTEP(s)](https://github.com/open-telemetry/oteps) # Don't think it was an OTEP but open-telemetry#2276 is where the push for the change originally came from I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OTEL-PHP at some point switched to using InstrumentationScope instead of InstrumentationLibrary everywhere, which incidentally satisfied the "Fetch InstrumentationScope from ReadableSpan" part of the spec (otel-php is still alpha so it seemed ok to not deprecate the instrumentation library and just remove it's use entirely)
Related issues #
open-telemetry/opentelemetry-php#705
Related OTEP(s) #
Don't think it was an OTEP but #2276 is where the push for the change originally came from I believe