spec matrix: remove duplicate mention of meter+scope association #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -161,8 +161,6 @@ formats is required. Implementing more than one format is optional. | |||
| | All methods of any instrument are safe to be called concurrently. | | + | + | + | - | | | | | + | + | | | |||
| | `MeterProvider` allows a `Resource` to be specified. | | + | + | + | + | | | + | + | + | + | | | |||
| | A specified `Resource` can be associated with all the produced metrics from any `Meter` from the `MeterProvider`. | | + | + | + | + | | | + | + | + | + | | | |||
| | The supplied `name`, `version` and `schema_url` arguments passed to the `MeterProvider` are used to create an `InstrumentationLibrary` instance stored in the `Meter`. | | + | - | | + | | | | + | + | - | | | |||
| | The supplied `name`, `version` and `schema_url` arguments passed to the `MeterProvider` are used to create an `InstrumentationScope` instance stored in the `Meter`. | | | + | + | | | | + | + | + | | | | |||
There was a problem hiding this comment.
Line 108 and this line were introduced by #2276
From I see the intent was to make it clear we want to replace Library by Scope and wanted to have a separate line item to track that the change is done by language implementations.
I am fine with eliminating the duplication and keeping just one line instead of 3, but we need to confirm that indeed the work of renaming Library to Scope is done by ALL languages, otherwise we will loose this particular compatibility nuance.
Can you confirm this with all languages where the 3 lines do not match exactly?
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate mentions of associating an InstrumentationScope with a Meter in the spec matrix.
Like with the Traces section there is already an entry for:
At first I was just removing the line mentioning InstrumentationLibrary but then realized I think this is just a duplicate of what is already listed in the matrix. The removed text is more descriptive than simply saying "associate" but matches the Traces section so I kept that one.