Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the stream_unique metric attribute at Detailed level #119

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Dec 12, 2023

This field has caused a (predictable) cardinality explosion in our internal pipeline monitoring setup. This leaves the feature in but disabled at Detailed level. While the collectorconfig package won't parse a value greater than Detailed, callers can still pass Detailed+1 to enable.

@jmacd jmacd changed the title Remove the stream_unique metric attribute LS-56301 Disable the stream_unique metric attribute at Detailed level Dec 12, 2023
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd merged commit b7ed304 into open-telemetry:main Dec 12, 2023
2 checks passed
@jmacd jmacd deleted the jmacd/remove_streamid branch May 22, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants