Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mixed-signal stream protocol entirely, cleanup receiver #136

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jan 16, 2024

Fixes #33.
Fixes #138.
Fixes #137.

Note: each of the OTel-Arrow stream definitions has the same, identical signature. Tests without-loss-of-generality use the Traces service method and client mocks in mock-based tests, as these in fact work for non-trace data because the signatures are identical.

Removes the stream entirely and updates the receiver code as #135 did for the exporter.

Note this also re-generates all the mock-based tests using go.uber.org/mock which is the new location for github.com/golang/mock. Two missing Makefile rules are saved, for the next time this needs to be done.

@jmacd jmacd changed the title Remove stream protocol entirely, cleanup receiver Remove mixed-signal stream protocol entirely, cleanup receiver Jan 16, 2024
@jmacd jmacd merged commit c9bd21a into open-telemetry:main Jan 17, 2024
1 check passed
@jmacd jmacd deleted the jmacd/nomixedstream branch January 17, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants