(otelarrowreceiver): add updown counters to track number of bytes and items pending #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
reviewed
Feb 8, 2024
jmacd
approved these changes
Feb 8, 2024
lquerel
reviewed
Feb 8, 2024
| if err := r.processAndConsume(thisCtx, method, ac, req, serverStream, authErr); err != nil { | ||
| return err | ||
| } | ||
| r.recvInFlightRequests.Add(thisCtx, -1) |
There was a problem hiding this comment.
Is it intended that the recvInFlightRequests up-down counter is never decremented when processAndConsume returns an error?
There was a problem hiding this comment.
I suggest adding the increment to the top of processAndConsume, with a defer func() { decrement() } to undo that count.
There was a problem hiding this comment.
Thanks for catching that @lquerel! This should be fixed now
moh-osman3
force-pushed
the
mohosman/inflight-updown-counter
branch
from
d126d71 to
4528377
Compare
jmacd
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #148
This PR adds two metrics to track the number of items and bytes that are pending in the receiver. Specifically when used with the
concurrentbatchprocessorrequests can be have a long lifetime in receiver due to the in flight byte limiter in theconcurrentbatchprocessor.