This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Add metric semantic conventions for timed operations #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfoote
force-pushed
the
timing_metrics_semantic_conventions
branch
from
1405c44 to
663ac61
Compare
jkwatson
approved these changes
Aug 6, 2020
gfuller1
approved these changes
Aug 6, 2020
MrAlias
approved these changes
Aug 6, 2020
|
@open-telemetry/specs-metrics-approvers would y'all have a look at this? I'd like us to come to an agreement sooner rather than later that we want some semantic conventions about naming and labeling of metrics, and that we're not intending to specify API or SDK changes with them. |
cijothomas
reviewed
Aug 10, 2020
| ### Naming | ||
|
|
||
| The semantic conventions should specify the naming of this metric instrument, following | ||
| the [Metric Instrument Naming Guidelines](./108-naming-guidelines.md#guidelines). |
jmacd
approved these changes
Aug 13, 2020
|
Any update on this? |
tedsuo
added
the
stale
|
@justinfoote we are marking OTEPs which are no longer being updated as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This OTEP attempts to address open-telemetry/opentelemetry-specification#654.
I'd like us to come to agreement that we ought to have semantic conventions describing timing metrics. These semantic conventions will describe what instrument(s) are created, how they are named, and what labels are applied to them. They will not describe how or where the instruments are created and incremented.