Forbid failing incidents from being scheduled in aggregates #154
Commits on Mar 5, 2024
-
-
-
Be lazy and setup the environment via Makefile
Let the build system die if any errors are found, this is intended for local development only.
-
-
-
-
Fix bug in initial implementation of has_failures
Leave early when filtering incidents to schedule, as incidents that have failures don't need further processing. Adjust tests accordingly fixing that ugly off by one
-
-
-
-
Handle job status and review comments properly
- While incidents are less likely to have an exception comment, there are cases where a failing aggregate from day before, might impact an incident on its own to be scheduled - We want to accept only passed results without questioning, anything else, will need to have an acceptable_for, following the discussion in [1] [1] https://github.com/openSUSE/qem-bot/pull/154/files#r1474042954
-
-
Extract copy&pasted regexp introduced in dd958dc
The code used by approver doesn't seem to use Incidents class and a rewrite at this point has less benefit than simply extracting the duplicated regular expression. A TODO has been left in place to keep track for subsequent PRs steming from discussion in [1] [1] openSUSE#154 (comment)
-
-
Update tests to new changes introduced to 62cb3d2
qem-bot's data is normalized, so either passed or failed.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.