Connections aren't being closed #140
Comments
|
Hi @dougli! Thanks for writing in. I'll surface this to the team and get it on our roadmap. That said, we happily accept PRs if you'd like to take a shot at fixing this. |
|
Any pointers where the sockets are opened or where they should be closed? I'm running into this issue |
|
In my case it helps to ignore the ResourceWarning by adding: import warnings
warnings.simplefilter("ignore", ResourceWarning)Doesn't fix the open filedescriptors, though |
|
We have deployed a dockerized application in production which crashes periodically because of this. Over time more and more connections are being opened until the container crashes because of a memory error. |
jhallard
added a commit
that referenced
this issue
Jun 5, 2023
…ndle issues (#179) As reported from the field - we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See #140 for more info.
jhallard
added a commit
that referenced
this issue
Jun 6, 2023
… with Docker Desktop (#478) * Periodically refresh open `requests.Session`s to mitigate open filehandle issues (#179) As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See #140 for more info. The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
luckdev2350
added a commit
to luckdev2350/openai_python
that referenced
this issue
May 9, 2024
… with Docker Desktop (#478) * Periodically refresh open `requests.Session`s to mitigate open filehandle issues (#179) As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See openai/openai-python#140 for more info. The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
risingstar0225
added a commit
to risingstar0225/openai_py
that referenced
this issue
Jul 26, 2024
… with Docker Desktop (#478) * Periodically refresh open `requests.Session`s to mitigate open filehandle issues (#179) As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See openai/openai-python#140 for more info. The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
megamanics
pushed a commit
to devops-testbed/openai-python
that referenced
this issue
Aug 14, 2024
… with Docker Desktop (openai#478) * Periodically refresh open `requests.Session`s to mitigate open filehandle issues (openai#179) As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See openai#140 for more info. The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
Watcher919
added a commit
to Watcher919/Python-openAI
that referenced
this issue
Sep 4, 2024
… with Docker Desktop (#478) * Periodically refresh open `requests.Session`s to mitigate open filehandle issues (#179) As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See openai/openai-python#140 for more info. The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this issue
Dec 14, 2024
… with Docker Desktop (openai#478) * Periodically refresh open `requests.Session`s to mitigate open filehandle issues (openai#179) As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server. See openai#140 for more info. The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The library uses
requeststo fetch data from OpenAI servers, but we never call.close()on those connections which leaves dangling open file handles on the OS.Can we clean these connections up gracefully, either after a period of time, or after making a request? There is an advantage to leaving it open as it doesn't have to do the HTTPS handshake on every request, but we should clean this up properly after a period of idleness.
This bug interacts very poorly with another bug in Docker Desktop -- moby/vpnkit#587; the
openailibrary stops working entirely after running it in a Docker container on Mac / Windows for a few minutes. All requests to OpenAI servers time out indefinitely.The text was updated successfully, but these errors were encountered: