Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Make the hybrid interface work for numpy>=2.0 #266

Merged
merged 4 commits into from
Jul 15, 2024
Merged

[fix] Make the hybrid interface work for numpy>=2.0 #266

merged 4 commits into from
Jul 15, 2024

Conversation

cdiener
Copy link
Member

@cdiener cdiener commented Jul 11, 2024

  • fix broken import of hybrid interface with numpy>=2.0
  • description of feature/fix
  • tests added/passed <- previous tests already checked it
  • add an entry to the next release

This replaces np.Infinity with the backwards compatible np.inf.

@cdiener cdiener changed the title switch to np.inf [fix] Make the hybrid interface work for numpy>=2.0 Jul 11, 2024
Midnighter
Midnighter reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I didn't check why all CI is failing.

@cdiener
Copy link
Member Author

cdiener commented Jul 12, 2024

Fails because of pyupio/safety#539 where safety itself will pull in a package with a vulnerability 🤦‍♂️

Midnighter
Midnighter approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cdiener cdiener merged commit 0443f19 into master Jul 15, 2024
13 checks passed
@cdiener cdiener mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdiener @Midnighter