Add lock on order when processing payment intent succeeded #10452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
reviewed
Nov 7, 2024
Comment on lines
251
to
259
| if (order) { | ||
| await order.update({ | ||
| data: previousOrderData, | ||
| }); | ||
| } | ||
|
|
||
| if (sequelizeTransaction) { | ||
| sequelizeTransaction.rollback(); | ||
| } |
There was a problem hiding this comment.
Two things here:
- Should we rather rollback before we update?
- It looks like we may end up calling
rollbackon an alreadycommited transaction (e.g. ifcreateOrUpdateOrderStripePaymentMethodfails). What would be the effect of that?
There was a problem hiding this comment.
- You're right, its best to put that rollback first to avoid deadlocking.
sequelizeTransactionis set to null right after its committed so this would be skipped.
Betree
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.