Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReversBits op added for transfer dialect #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ReversBits op added for transfer dialect #43

wants to merge 3 commits into from

Conversation

Hatsunespica
Copy link
Collaborator

No description provided.

math-fehr
math-fehr reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, can you look at them?
Also, can you add a simple test with it, just something that asserts that reverse_bits(0b10010) == 0b01001 for instance?

xdsl_smt/dialects/transfer.py Show resolved Hide resolved
xdsl_smt/semantics/transfer_semantics.py Outdated Show resolved Hide resolved
xdsl_smt/semantics/transfer_semantics.py Show resolved Hide resolved
xdsl_smt/semantics/transfer_semantics.py Show resolved Hide resolved
xdsl_smt/semantics/transfer_semantics.py Show resolved Hide resolved
xdsl_smt/semantics/transfer_semantics.py Show resolved Hide resolved
xdsl_smt/semantics/transfer_semantics.py Show resolved Hide resolved
xdsl_smt/utils/transfer_to_smt_util.py Outdated Show resolved Hide resolved
xdsl_smt/utils/transfer_to_smt_util.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@math-fehr math-fehr math-fehr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hatsunespica @math-fehr