juniper ncptx model #349
Merged
juniper ncptx model #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first commit to enable juniper ncptx container model
Pull Request Test Coverage Report for Build 5293610836
💛 - Coveralls |
|
Assigned to Marcus for review as he has been trying out ncptx in KNE |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
Strange - resolved merge conflict with main and pushed a merge commit but don't see it here. |
NVM, it took some time |
alexmasi
reviewed
Jun 13, 2023
alexmasi
reviewed
Jun 13, 2023
remove some defauts from KNE config change the env variable to a meaningful name fix test.go to match
alexmasi
reviewed
Jun 15, 2023
|
/gcbrun |
alexmasi
previously approved these changes
Jun 16, 2023
|
/gcbrun |
alexmasi
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first commit to enable juniper ncptx container model