Add event proto #387
Merged
Add event proto #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5340073208
💛 - Coveralls |
|
/gcbrun |
bormanp
previously requested changes
Jun 21, 2023
proto/event.proto
Outdated
| message Node { | ||
| topo.Vendor vendor = 1; | ||
| string model = 2; | ||
| string version = 3; |
There was a problem hiding this comment.
How important are version and os? Wouldn't these be determinable from the vendor/model? There probably should be a comment justifying each piece of information gathered.
There was a problem hiding this comment.
Added comments. Version and OS provide much less value than knowing the vendor+model so I've removed them.
|
/gcbrun |
bormanp
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used in anonymous usage reporting