Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work towards cptx deprecation #497

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Work towards cptx deprecation #497

merged 5 commits into from
Feb 20, 2024

Conversation

alexmasi
Copy link
Contributor

This PR changes the default of juniper from cptx to ncptx.

Also remove cptx from our presubmit

Additionally change the multivendor example to use ncptx so a nested virt enabled host is not required.

@alexmasi alexmasi requested a review from guoshiuan February 16, 2024 01:16
@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 7980622631

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.6%

Totals Coverage Status
Change from base Build 7936739246: 0.0%
Covered Lines: 4353
Relevant Lines: 6536

💛 - Coveralls

@alexmasi
Copy link
Contributor Author

/gcbrun

1 similar comment
@alexmasi
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@NehaManjunath NehaManjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmasi alexmasi merged commit 39a7e78 into main Feb 20, 2024
9 checks passed
@alexmasi alexmasi deleted the ncptx branch February 20, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants