check that StartTransientUnit succeeds

Signed-off-by: lifubang <[email protected]>

libcontainer/cgroups/systemd/v2.go

@@ -15,6 +15,7 @@ import (
 	"github.com/opencontainers/runc/libcontainer/cgroups"
 	"github.com/opencontainers/runc/libcontainer/cgroups/fs2"
 	"github.com/opencontainers/runc/libcontainer/configs"
+	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 )
 
@@ -139,7 +140,11 @@ func (m *unifiedManager) Apply(pid int) error {
 	statusChan := make(chan string, 1)
 	if _, err := dbusConnection.StartTransientUnit(unitName, "replace", properties, statusChan); err == nil {
 		select {
-		case <-statusChan:
+		case s := <-statusChan:
+			if s != "done" {
+				dbusConnection.ResetFailedUnit(unitName)
+				return errors.Errorf("error creating systemd unit `%s`: got `%s`", unitName, s)
+			}
 		case <-time.After(time.Second):
 			logrus.Warnf("Timed out while waiting for StartTransientUnit(%s) completion signal from dbus. Continuing...", unitName)
 		}
@@ -168,7 +173,18 @@ func (m *unifiedManager) Destroy() error {
 	if err != nil {
 		return err
 	}
-	dbusConnection.StopUnit(getUnitName(m.cgroups), "replace", nil)
+	unitName := getUnitName(m.cgroups)
+	statusChan := make(chan string, 1)
+	if _, err := dbusConnection.StopUnit(unitName, "replace", statusChan); err == nil {
+		select {
+		case s := <-statusChan:
+			if s != "done" {
+				logrus.Warnf("error removing unit `%s`: got `%s`. Continuing...", unitName, s)
+			}
+		case <-time.After(time.Second):
+			logrus.Warnf("Timed out while waiting for StopUnit(%s) completion signal from dbus. Continuing...", unitName)
+		}
+	}
 
 	// XXX this is probably not needed, systemd should handle it
 	err = os.Remove(m.path)