libct/cgroups: support Cgroups.Resources.Unified #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
unified-support
branch
from
9dfede1 to
f2fc11b
Compare
|
That intermittent download failure, again Wonder if there's a better alternative. For some reason, this never happens to any other URLs downloaded from github |
kolyshkin
force-pushed
the
unified-support
branch
from
f2fc11b to
9c7ff8d
Compare
|
Rebased |
AkihiroSuda
reviewed
Sep 11, 2020
... to include unified resources support. Signed-off-by: Kir Kolyshkin <[email protected]>
As the underlying error message from iotuils.WriteFile already contains file name, there's no need to put it, otherwise we end up with something like: failed to write "val" to "/sys/fs/cgroup/.../file": open /sys/fs/cgroup/.../file: permission denied With this patch, the error will be failed to write "val": open /sys/fs/cgroup/.../file: permission denied Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
unified-support
branch
from
9c7ff8d to
d0397b9
Compare
AkihiroSuda
reviewed
Sep 17, 2020
AkihiroSuda
reviewed
Sep 17, 2020
kolyshkin
force-pushed
the
unified-support
branch
from
d0397b9 to
ce81593
Compare
|
Added bats test with more unified parameters (using only |
AkihiroSuda
previously approved these changes
Sep 21, 2020
|
@giuseppe PTAL? |
kolyshkin
force-pushed
the
unified-support
branch
from
ce81593 to
8e94e5e
Compare
giuseppe
reviewed
Sep 22, 2020
kolyshkin
force-pushed
the
unified-support
branch
from
8e94e5e to
ab1ce70
Compare
|
LGTM |
mrunalp
reviewed
Sep 24, 2020
mrunalp
previously approved these changes
Sep 24, 2020
Add support for unified resource map (as per [1]), and add some test cases for the new functionality. [1] opencontainers/runtime-spec#1040 Signed-off-by: Kir Kolyshkin <[email protected]>
Container test_cgroups_group was missing from the teardown. Fixes: c91fe9a. Signed-off-by: Kir Kolyshkin <[email protected]>
Note that various invalid keys are covered by test cases in libcontainer/integration/exec_test.go Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
unified-support
branch
from
ab1ce70 to
4929c05
Compare
mrunalp
approved these changes
Sep 25, 2020
|
@AkihiroSuda ptal |
AkihiroSuda
approved these changes
Sep 26, 2020
|
@kolyshkin Could you open an issue for tracking systemd issue? |
I'm not quite sure which way to go -- let's discuss in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for unified resource map (as per [1]), and add some test
cases for the new functionality.
[1] opencontainers/runtime-spec#1040
Fixes: #2563
The biggest issue, I think, is that the mapping of the "unified" parameters
to systemd properties is not implemented, meaning there can be cases
where systemd unit settings and in-kernel cgroup settings won't agree.
I don't think it can cause any issues, but it's just doesn't look right.