Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement birth v2 #8274

Merged
merged 39 commits into from
Jan 16, 2025
Merged

Feat: implement birth v2 #8274

merged 39 commits into from
Jan 16, 2025

Conversation

jamil314
Copy link
Collaborator

@jamil314 jamil314 commented Jan 1, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

jamil314 and others added 15 commits January 2, 2025 15:05
jamil314
jamil314 commented Jan 9, 2025
View reviewed changes
Copy link
Collaborator Author

@jamil314 jamil314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Country config pr: opencrvs/opencrvs-countryconfig#353

@rikukissa rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 10, 2025
@jamil314 jamil314 mentioned this pull request Jan 15, 2025
Closed
makelicious
makelicious reviewed Jan 15, 2025
View reviewed changes
packages/commons/src/events/FieldConfig.ts Outdated Show resolved Hide resolved
packages/commons/src/events/FieldConfig.ts Show resolved Hide resolved
packages/toolkit/src/conditionals/index.ts Show resolved Hide resolved
packages/client/src/v2-events/features/events/components/Review.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/registered-fields/SelectCountry.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/registered-fields/CheckBox.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/registered-fields/Select.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/registered-fields/Select.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/registered-fields/SelectCountry.tsx Show resolved Hide resolved
packages/commons/src/events/FieldConfig.ts Outdated Show resolved Hide resolved
@makelicious
Copy link
Collaborator

Looks good! cosmetic changes and then ready to go

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://feat-birth-v2.opencrvs.dev

@jamil314 jamil314 deployed to feat-birth-v2 January 16, 2025 11:05 — with GitHub Actions Active
@jamil314 jamil314 merged commit c11de6e into develop Jan 16, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa rikukissa left review comments

@makelicious makelicious makelicious approved these changes

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 💅 Waiting For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamil314 @makelicious @ocrvs-bot @rikukissa