-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle unexpected state when a record is viewed before registration confirmation #8299
Conversation
… set to awaiting validation and country config confirming the record
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I checked other uses of createNewTaskResource
and unless there are more non-null assertions way up in the chain, we should be good.
If we feel extra paranoid, we could clean up the incoming extensions in createNewTaskResource
. However, it does not address any specific issue but rather vaguely just "deals with it", even if it should not happen anymore.
Thanks for the review! Yea, I tend to err on the side of not dong anything "just in case" so the code always represents the real known cases. I clarified the tests and addressed other feedback |
Root cause: