Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events v2 collect certificate workflow boilerplate code #8321

Merged
merged 31 commits into from
Feb 4, 2025
Merged

Events v2 collect certificate workflow boilerplate code #8321

merged 31 commits into from
Feb 4, 2025
+2,414 −136

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Jan 10, 2025 •
edited
Loading

#7919

corresponding country config pull request: opencrvs/opencrvs-countryconfig#360

@tareq89 tareq89 requested a review from rikukissa January 10, 2025 14:32
@tareq89 tareq89 self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@tareq89 tareq89 marked this pull request as draft January 10, 2025 14:52
@rikukissa rikukissa requested a review from makelicious January 13, 2025 02:53
rikukissa
rikukissa approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rikukissa rikukissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tareq89 tareq89 force-pushed the ocrvs-event-v2-7919 branch from ab0e65e to 5bce870 Compare January 14, 2025 16:09
@tareq89 tareq89 force-pushed the ocrvs-event-v2-7919 branch from 5bce870 to 8566d57 Compare January 15, 2025 05:14
makelicious
makelicious reviewed Jan 15, 2025
View reviewed changes
packages/client/src/v2-events/components/forms/FormFieldGenerator.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/collect-certificate/Review.tsx Outdated Show resolved Hide resolved
packages/commons/src/events/AppConfig.ts Outdated Show resolved Hide resolved
packages/commons/src/events/AppConfig.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/hooks/utils/certificateUtils.ts Outdated Show resolved Hide resolved
@tareq89 tareq89 force-pushed the ocrvs-event-v2-7919 branch from 8566d57 to 35f3822 Compare January 16, 2025 15:53
@tareq89 tareq89 force-pushed the ocrvs-event-v2-7919 branch from 35f3822 to 29ac67d Compare January 20, 2025 15:53
@tareq89 tareq89 force-pushed the ocrvs-event-v2-7919 branch from 2c19902 to 1dc80c7 Compare January 23, 2025 11:22
makelicious
makelicious reviewed Jan 30, 2025
View reviewed changes
packages/client/src/v2-events/utils/pdf/PDFUtils.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/printPDF.ts Outdated Show resolved Hide resolved
packages/commons/src/events/ActionConfig.ts Outdated Show resolved Hide resolved
packages/commons/src/events/index.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/imageUtils.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/PDFUtils.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/PDFUtils.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/PDFUtils.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/PDFUtils.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/PDFUtils.ts Outdated Show resolved Hide resolved
makelicious
makelicious reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@makelicious makelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some clean up suggestions. Let's add tests to backend

packages/client/src/v2-events/STYLEGUIDE.md Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/events/actions/print-certificate/Pages.tsx Outdated Show resolved Hide resolved
packages/events/src/router/event/index.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/hooks/usePrintableCertificate.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/hooks/usePrintableCertificate.ts Show resolved Hide resolved
packages/client/src/v2-events/utils/pdf/PdfUtils.ts Outdated Show resolved Hide resolved
.../client/src/v2-events/features/events/actions/print-certificate/PrintCertificate.stories.tsx Outdated Show resolved Hide resolved
@tareq89 tareq89 requested a review from makelicious February 3, 2025 06:22
@tareq89 tareq89 enabled auto-merge (squash) February 3, 2025 08:22
@tareq89 tareq89 dismissed rikukissa’s stale review February 3, 2025 08:23

All the change request by Riku has been done

@tareq89 tareq89 merged commit 77c8404 into develop Feb 4, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamil314 jamil314 jamil314 left review comments

@makelicious makelicious makelicious approved these changes

@naftis naftis naftis left review comments

@rikukissa rikukissa rikukissa left review comments

Assignees

@tareq89 tareq89

Labels
💅 Waiting For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tareq89 @ocrvs-bot @rikukissa @naftis @makelicious @jamil314